-
Notifications
You must be signed in to change notification settings - Fork 128
Update SBT, Scala.js, Scala Native, and plugins #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @keynmol! But with the sbt update there are some changes with the way all the cross versions are set up. That's where the work actually is, and I didn't have time to dig into. |
I am assuming that SBT 1.7.0 is the one introducing changes to how cross versions work: https://github.com/sbt/sbt/releases/tag/v1.7.0
Which is in contrast with the way runtime and reporter are set up in this project. I added a couple of hacks to see how the tests go (they pass locally), but we can think of an actual fix |
libraryDependencies += "org.scala-lang" % "scala-compiler" % scalaVersion.value % Provided, | ||
sharedSettings | ||
sharedSettings, | ||
allowUnsafeScalaLibUpgrade := true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also set runtime to have allowUnsafeScalaLibUpgrade := true,
, we should be ok to do that.
Or alternatively ask Seb to release Scala JS 2.13.17 on 1.19.0
Alternatively, do we need to cross publish JS on every Scala version as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckipp01 if you'd like I can help with day to day maintenance, is it possible to add me to the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scala.js 1.20.1 support for 2.13.17 is published.
We will not publish earlier versions, as they predate the Sonatypocalypse. Their build cannot publish to the new Central Portal.
https://contributors.scala-lang.org/t/scala-2-13-17-release-planning/6994/18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change the build and release manually, though maybe with Scala JS it's much harder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckipp01 if you'd like I can help with day to day maintenance, is it possible to add me to the repo?
Yup, just added you. Everything is set up for creds to publish on a tag, everything just needs to be updated. You should have access to the sbt repo as well, but that one is up to date.
My understanding is that this should be enough for publishing as long as the credentials in this repo have been rotate since the Central Portal migratio.